Retain operation level parameters over path level ones

Sources/_OpenAPIGeneratorCore/Translator/Operations/OperationDescription.swift

@@ -144,10 +144,30 @@ extension OperationDescription {
  )
  }
 
- /// Returns parameters from both the path item level
- /// and the operation level.
+ /// Merged parameters from both the path item level and the operation level.
+ /// If duplicate parameters exist, only the parameters from the operation level are preserved.
+ ///
+ /// - Returns: An array of merged path item and operation level parameters without duplicates.
+ /// - Throws: When an invalid JSON reference is found.
  var allParameters: [UnresolvedParameter] {
- pathParameters + operation.parameters
+ get throws { 
+ var mergedParameters: [UnresolvedParameter] = []
+ var uniqueIdentifiers: Set<String> = []
+
+ for parameter in pathParameters + operation.parameters {
+ let resolvedParameter = try parameter.resolve(in: components)
+ let identifier = resolvedParameter.location.rawValue + ":" + resolvedParameter.name
+
+ guard !uniqueIdentifiers.contains(identifier) else { 
+ continue 
+ }
+
+ mergedParameters.append(parameter)
+ uniqueIdentifiers.insert(identifier)
+ }
+
+ return mergedParameters
+ }
  }
 
  /// Returns all parameters by resolving any parameter references first.

Tests/OpenAPIGeneratorCoreTests/Translator/Operations/Test_OperationDescription.swift

@@ -0,0 +1,112 @@
+//===----------------------------------------------------------------------===//
+//
+// This source file is part of the SwiftOpenAPIGenerator open source project
+//
+// Copyright (c) 2023 Apple Inc. and the SwiftOpenAPIGenerator project authors
+// Licensed under Apache License v2.0
+//
+// See LICENSE.txt for license information
+// See CONTRIBUTORS.txt for the list of SwiftOpenAPIGenerator project authors
+//
+// SPDX-License-Identifier: Apache-2.0
+//
+//===----------------------------------------------------------------------===//
+import OpenAPIKit30
+import XCTest
+@testable import _OpenAPIGeneratorCore
+
+final class Test_OperationDescription: Test_Core {
+
+ func testAllParameters_duplicates_retainOnlyOperationParameters() throws {
+ let allParameters = try _test(
+ """
+ openapi: "3.0.0"
+ info:
+ title: "Test"
+ version: "1.0.0"
+ paths:
+ /system:
+ get:
+ description: This is a unit test.
+ responses:
+ '200':
+ description: Success
+ parameters:
+ - name: test
+ in: query
+ schema:
+ type: string
+ parameters:
+ - name: test
+ in: query
+ schema:
+ type: integer
+ """
+ )
+
+ XCTAssertEqual(
+ allParameters,
+ [.b(OpenAPI.Parameter(name: "test", context: .query(required: false), schema: .integer))]
+ )
+ }
+
+ func testAllParameters_duplicates_keepsDuplicatesAtDifferentLocation() throws {
+ let allParameters = try _test(
+ """
+ openapi: "3.0.0"
+ info:
+ title: "Test"
+ version: "1.0.0"
+ paths:
+ /system:
+ get:
+ description: This is a unit test.
+ responses:
+ '200':
+ description: Success
+ parameters:
+ - name: test
+ in: query
+ schema:
+ type: string
+ parameters:
+ - name: test
+ in: path
+ required: true
+ schema:
+ type: integer
+ """
+ )
+
+ XCTAssertEqual(
+ allParameters,
+ [
+ .b(OpenAPI.Parameter(name: "test", context: .path, schema: .integer)),
+ .b(OpenAPI.Parameter(name: "test", context: .query(required: false), schema: .string))
+ ]
+ )
+ }
+
+ private func _test(_ yaml: String) throws -> [UnresolvedParameter] {
+ let document = try YamsParser()
+ .parseOpenAPI(
+ .init(
+ absolutePath: URL(fileURLWithPath: "/foo.yaml"),
+ contents: Data(yaml.utf8)
+ ),
+ config: .init(mode: .types),
+ diagnostics: PrintingDiagnosticCollector()
+ )
+
+ guard let operationDescription = try OperationDescription.all(
+ from: document.paths,
+ in: document.components,
+ asSwiftSafeName: { $0 }
+ ).first else {
+ XCTFail("Unable to retrieve the operation description.")
+ return []
+ }
+
+ return try operationDescription.allParameters
+ }
+}