Update re-usable workflows to use nightly_next #3122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Motivation: Updating the CI parameters for changing nightly job targets with each new Swift version (6.0, 6.1, ...) is onerous. Whilst this gives us some value in the non-nightly pipelines by forcing adopters to apply thought to what is applied to each supported version, the nightlies arguably deliver less value in this regard as they tend to be non-required. Modifications: Change parameters to refer to nightly_next rather than nightly_6_1, implement a shim so that the old environment variables still work. Result: We will be able to modify top-level workflows to use nightly_next terminology.
This reverts commit ea81502.
Lukasa approved these changes Mar 3, 2025
This was referenced Mar 3, 2025
Lukasa pushed a commit to apple/swift-http-structured-headers that referenced this pull request Mar 3, 2025
Rename nightly_6_1 params to nightly_next; see apple/swift-nio#3122
Lukasa pushed a commit to apple/swift-crypto that referenced this pull request Mar 3, 2025
Rename nightly_6_1 params to nightly_next; see apple/swift-nio#3122
Lukasa pushed a commit to apple/swift-certificates that referenced this pull request Mar 3, 2025
Rename nightly_6_1 params to nightly_next; see apple/swift-nio#3122
Lukasa pushed a commit to apple/swift-asn1 that referenced this pull request Mar 3, 2025
Rename nightly_6_1 params to nightly_next; see apple/swift-nio#3122
Lukasa pushed a commit to swift-server/async-http-client that referenced this pull request Mar 3, 2025
Rename nightly_6_1 params to nightly_next; see apple/swift-nio#3122
Lukasa pushed a commit to apple/swift-nio-ssh that referenced this pull request Mar 3, 2025
Move nightly-next thresholds and add legacy symlink; see apple/swift-nio#3122
Lukasa pushed a commit to apple/swift-http-types that referenced this pull request Mar 3, 2025
Rename nightly_6_1 params to nightly_next; see apple/swift-nio#3122
Lukasa pushed a commit to apple/swift-asn1 that referenced this pull request Mar 3, 2025
Move nightly-next thresholds and add legacy symlink; see apple/swift-nio#3122
Lukasa pushed a commit to apple/swift-nio-ssl that referenced this pull request Mar 3, 2025
Move nightly-next thresholds and add legacy symlink; see apple/swift-nio#3122
Lukasa pushed a commit to apple/swift-nio-http2 that referenced this pull request Mar 3, 2025
Move nightly-next thresholds and add legacy symlink; see apple/swift-nio#3122
glbrntt pushed a commit to grpc/grpc-swift-nio-transport that referenced this pull request Mar 3, 2025
Rename nightly_6_1 params to nightly_next; see apple/swift-nio#3122
Lukasa pushed a commit to apple/swift-certificates that referenced this pull request Mar 3, 2025
Move nightly-next thresholds and add legacy symlink; see apple/swift-nio#3122
rnro added a commit to grpc/grpc-swift that referenced this pull request Mar 3, 2025
Rename nightly_6_1 params to nightly_next; see apple/swift-nio#3122
rnro added a commit that referenced this pull request Mar 4, 2025
Use nightly_next as swift version see #3122 Motivation: To not have to rename threshold directories when the nightly branch changes. Modifications: * Use nightly_next as swift version in the matrix generation script which is picked up by the benchmark script. * Move nightly-next thresholds and add legacy symlink Result: Benchmark thresholds will attempt to find directories named nightly_next, not nightly_6_1.
rnro added a commit to apple/swift-openapi-runtime that referenced this pull request Mar 4, 2025
Rename nightly_6_1 params to nightly_next; see apple/swift-nio#3122
rnro added a commit to apple/swift-openapi-urlsession that referenced this pull request Mar 4, 2025
Rename nightly_6_1 params to nightly_next; see apple/swift-nio#3122
rnro added a commit to apple/swift-openapi-generator that referenced this pull request Mar 4, 2025
Rename nightly_6_1 params to nightly_next; see apple/swift-nio#3122
rnro added a commit to apple/swift-log that referenced this pull request Mar 4, 2025
Rename nightly_6_1 params to nightly_next; see apple/swift-nio#3122
rnro added a commit to swift-server/swift-kafka-client that referenced this pull request Mar 4, 2025
Rename nightly_6_1 params to nightly_next; see apple/swift-nio#3122
rnro added a commit to apple/swift-cluster-membership that referenced this pull request Mar 4, 2025
Rename nightly_6_1 params to nightly_next; see apple/swift-nio#3122
rnro added a commit to apple/swift-cassandra-client that referenced this pull request Mar 4, 2025
Rename nightly_6_1 params to nightly_next; see apple/swift-nio#3122
glbrntt pushed a commit to glbrntt/grpc-swift-protobuf that referenced this pull request Mar 5, 2025
Rename nightly_6_1 params to nightly_next; see apple/swift-nio#3122
rnro added a commit to swift-server/swift-openapi-async-http-client that referenced this pull request Mar 14, 2025
Rename nightly_6_1 params to nightly_next; see apple/swift-nio#3122
rnro added a commit to apple/swift-async-dns-resolver that referenced this pull request Apr 2, 2025
Rename nightly_6_1 params to nightly_next; see apple/swift-nio#3122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation:
Updating the CI parameters for changing nightly job targets with each
new Swift version (6.0, 6.1, ...) is onerous. Whilst this gives us some
value in the non-nightly pipelines by forcing adopters to apply thought
to what is applied to each supported version, the nightlies arguably
deliver less value in this regard as they tend to be non-required.
Modifications:
Change parameters to refer to nightly_next rather than nightly_6_1, implement
a shim so that the old parameter names still work.
Result:
We will be able to modify top-level workflows to use nightly_next
terminology.
Test run with an additional commit opting in to use these changes at the top level https://github.com/apple/swift-nio/actions/runs/13524774485/job/37792437713?pr=3122