Fix compilation on platforms without Foundation.Process #1209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rnro approved these changes May 8, 2025
Contributor Author
| Looks like a flakey test struggling to establish the cluster before terminating it, timing out after 5 seconds. Runs locally without reproducing 100 times in a row. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation:
There's an open PR to add CI for Apple platforms. This is currently failing since it tries to build for all Apple platforms, not just macOS. This is because there are targets that provide support for testing that rely on
Foundation.process, which is unavailable on non-macOS Apple platforms.Modifications:
Guard the use of
Foundation.Processwith an#if canImport.Result:
Package builds for non-macOS Apple platforms: iOS, tvOS, watchOS, etc.