This repository was archived by the owner on Mar 28, 2020. It is now read-only.
[APINotes] Record what version caused an annotation to get replaced. #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jrose-apple force-pushed the apinotes-record-replacement branch 2 times, most recently from f95fc08 to 5251264 Compare 
| I think I'm going to have to make this an option, sadly, or else we're going to have a Clang/Swift revlock. (where the Swift change is non-trivial) |
| …ah, well, maybe that's acceptable. update-checkout all the working copies! |
Now that -fapinotes-swift-version=3 can pick up API notes for "Version: 4", the information for /inactive/ API notes isn't sufficient to tell what would have happened under a different version. That is, I can't ask "what would happen under version 4", because I can't tell if the active annotations are active because they were specified for version 3 or version 4. The inactive, unversioned attributes were no help, either: they just said "version 0". Fix this by adding a new flag 'IsReplacedByActive' to SwiftVersionedAttr and SwiftVersionedRemovalAttr. When set, the 'Version' field refers to the API note that caused this annotation to become inactive. Note that "version 0" can still exist: when an attribute written in source is replaced by an unversioned attribute in the API notes.
jrose-apple force-pushed the apinotes-record-replacement branch from 5251264 to 79fdcc2 Compare jrose-apple added a commit to jrose-apple/swift-clang that referenced this pull request Sep 15, 2017
…pple#123) Now that -fapinotes-swift-version=3 can pick up API notes for "Version: 4", the information for /inactive/ API notes isn't sufficient to tell what would have happened under a different version. That is, I can't ask "what would happen under version 4", because I can't tell if the active annotations are active because they were specified for version 3 or version 4. The inactive, unversioned attributes were no help, either: they just said "version 0". Fix this by adding a new flag 'IsReplacedByActive' to SwiftVersionedAttr and SwiftVersionedRemovalAttr. When set, the 'Version' field refers to the API note that caused this annotation to become inactive. Note that "version 0" can still exist: when an attribute written in source is replaced by an unversioned attribute in the API notes. (cherry picked from commit b9c7251)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
(Depends on #122; this PR is intended for just the third commit.)
Now that -fapinotes-swift-version=3 can pick up API notes for "Version: 4", the information for inactive API notes isn't sufficient to tell what would have happened under a different version. That is, I can't ask "what would happen under version 4", because I can't tell if the active annotations are active because they were specified for version 3 or version 4. The inactive, unversioned attributes were no help, either: they just said "version 0".
Fix this by adding a new flag 'IsReplacedByActive' to SwiftVersionedAttr and SwiftVersionedRemovalAttr. When set, the 'Version' field refers to the API note that caused this annotation to become inactive.
Note that "version 0" can still exist: when an attribute written in source is replaced by an unversioned attribute in the API notes.