Skip to content

Conversation

rauhul
Copy link
Contributor

@rauhul rauhul commented Feb 6, 2025

Many tests previously included rendered output in Swift source files as
multiline strings. This made updating them very tedious and made diffs
very hard to follow.

This add snapshot directories to avoid needing to include rendered test
in the source files and adds an easy way of recording new snapshots as
needed.

@rauhul rauhul requested a review from natecook1000 February 6, 2025 00:50
@rauhul
Copy link
Contributor Author

rauhul commented Feb 6, 2025

@swift-ci test

@rauhul rauhul enabled auto-merge (squash) February 6, 2025 00:50
@rauhul rauhul force-pushed the json-files-for-dump-help branch from a1c1d65 to 76a934d Compare February 6, 2025 00:51
@rauhul
Copy link
Contributor Author

rauhul commented Feb 6, 2025

@swift-ci test

@rauhul rauhul force-pushed the json-files-for-dump-help branch from 76a934d to 8caa67a Compare February 6, 2025 01:27
@rauhul
Copy link
Contributor Author

rauhul commented Feb 6, 2025

@swift-ci test

@rauhul rauhul changed the title Refactor dump help tests Snapshot files for tests Feb 6, 2025
Many tests previously included rendered output in Swift source files as multiline strings. This made updating them very tedious and made diffs very hard to follow. This add snapshot directories to avoid needing to include rendered test in the source files and adds an easy way of recording new snapshots as needed.
@rauhul rauhul force-pushed the json-files-for-dump-help branch from 8caa67a to 0c2f97a Compare February 6, 2025 01:40
@rauhul
Copy link
Contributor Author

rauhul commented Feb 6, 2025

@swift-ci test

@rauhul rauhul merged commit c2d8414 into main Feb 6, 2025
2 checks passed
@rauhul rauhul deleted the json-files-for-dump-help branch February 6, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant