Don't remove nested option group titles #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
When option groups are nested, any titles of the nested groups are removed, even when the containing group doesn't have a title. This change preserves the nested groups' titles when grouped in an untitled option group. Nesting within a titled option group continues to override any nested option groups. Fixes apple#585.
| @swift-ci Please test |
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When option groups are nested, any titles of the nested groups are removed, even when the containing group doesn't have a title. This change preserves the nested groups' titles when grouped in an untitled option group. Nesting within a titled option group continues to override any nested option groups.
Fixes #585.
Checklist