Disfavor deprecated property wrapper inits #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This change is to make sure that the non-optional generic parameter type is chosen for @argument and @option properties that provide a default value. Previously, an optional type might be chosen depending on how the `help` parameter was spelled, due to strange overload resolution. In particular, using the `.init` caused selection of the deprecated optional overload: // Unexpected: // Infers `Value` as `Optional<AbsolutePath>` @argument(help: .init("The path")) var path = AbsolutePath("/") // Expected: // Infers `Value` as `AbsolutePath` @argument(help: "The path") var path = AbsolutePath("/") This addresses the issue by marking the deprecated overloads as disfavored. rdar://102383455
| @swift-ci Please test |
rauhul reviewed Nov 16, 2022
| wrappedValue: Value, | ||
| help: ArgumentHelp? = nil, | ||
| completion: CompletionKind? = nil | ||
| ) where Value: ExpressibleByArgument { |
There was a problem hiding this comment.
Just curious: does this change affect overload resolution?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This change is to make sure that the non-optional generic parameter type is chosen for
@Argumentand@Optionproperties that provide a default value. Previously, an optional type might be chosen depending on how thehelpparameter was spelled, due to strange overload resolution. In particular, using the.initcaused selection of the deprecated optional overload:This addresses the issue by marking the deprecated overloads as disfavored. rdar://102383455
Checklist