fix: 🐛 Declare GenerateManualPlugin as plugin product

[MarcoEidinger]

✅ Closes: #455

ArgumentParser 1.1.3 includes a SwiftPM plugin for generating man pages. However, this plugin is not visible to packages that declare ArgumentParser as a package dependency.

Defining a product of type plugin in the package manifest will solve that. Running swift package plugin --list for a package, that declares ArgumentParser as a package dependency, will then list the GenerateManualPlugin

‘experimental-generate-manual’ (plugin ‘GenerateManualPlugin’ in package ‘swift-argument-parser’) 

Checklist

• I've added at least one test that validates that my change is working, if appropriate
• I've followed the code style of the rest of the project
• I've read the Contribution Guidelines
• I've updated the documentation if necessary

[rauhul]

Thanks

[rauhul]

@swift-ci please test

[MarcoEidinger]

Is this PR good to be merged or do you need anything else?

[rauhul]

Yeah it looks good to me but I'd like @natecook1000 to sign off first.

[MarcoEidinger]

Hi @natecook1000, this PR provides the fix for generating man pages from the consumer's package root. Would love to see this getting merged soon :)

[rauhul]

I believe Nate will be able to approve this in the upcoming week; sorry about the wait.

[rauhul]

Spoke to Nate offline and this looks good. Thanks for your patience!

[MarcoEidinger]

Awesome! What is the ETA for a new release (1.1.4) that will include the fix? After all, the feature to generate man pages is otherwise only working for people pinning to the main branch.

[rauhul]

1.1.4 has been released with this fix.