Skip to content

Stop parsing earlier when a catch-all argument is present #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2021
Merged

Stop parsing earlier when a catch-all argument is present #333

merged 2 commits into from
Jul 2, 2021

Conversation

natecook1000
Copy link
Member

@natecook1000 natecook1000 commented Jun 29, 2021 •
edited
Loading

If a command defines an @Argument property with the .unconditionalRemaining parsing strategy, we need to stop parsing input when we encounter either a positional argument or an unrecognized option/flag label. Note that this is a change in behavior, as seen in the modified test.

Resolves #331.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary
@natecook1000
Stop parsing earlier when a catch-all argument is present
6bad843 
If a command defines an @argument property with the .unconditionalRemaining parsing strategy, we need to stop parsing input when we encounter either a positional argument or an unrecognized option/flag label. Note that this is a change in behavior, as seen in the modified test. Resolves #331.
@natecook1000 natecook1000 added the breaking change A change that would impact existing library users label Jun 29, 2021
@natecook1000 natecook1000 requested a review from Azoy June 29, 2021 22:04
@natecook1000
Copy link
Member Author

@swift-ci Please test
@natecook1000 natecook1000 merged commit 23f7265 into main Jul 2, 2021
@natecook1000 natecook1000 deleted the nate/repeated_flag_with_catchall branch July 2, 2021 22:39
@didix21 didix21 mentioned this pull request Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change A change that would impact existing library users

2 participants

@natecook1000 @Azoy