Make trace event field lengths default knobified and individually configurable. #1844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ied and configurable. Add a transaction option to control the field length of transaction debug logging. Make the program start command line field less likely to be truncated.
alecgrieser requested changes Jul 15, 2019
Contributor
alecgrieser left a comment
alecgrieser left a comment There was a problem hiding this comment.
In general, this looks good. Just a few nit picks, mostly about naming things...
… functions, so don't use override.
Co-Authored-By: Alec Grieser <alloc@apple.com>
alecgrieser approved these changes Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add a transaction option to control the field length of transaction debug logging. Make the program start command line field less likely to be truncated.