Improve the recovery speed of the txnStateStore #1729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| self->cursor = self->logSystem->peekTxs( UID(), self->recoveryLoc, self->peekLocality ? self->peekLocality->get().primaryLocality : tagLocalityInvalid, self->peekLocality ? self->peekLocality->get().knownCommittedVersion : invalidVersion ); | ||
| self->localityChanged = self->peekLocality->onChange(); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I had to put a wait(delay(0)) above the continue; on line 69, because getMore returns when there's a message, or when the version changes, and it appears we now have a very large number of version changes in a row. When that happens, there's a loop of wait(getMore) -> break -> !hasMessage() -> continue -> wait(getMore) that overflows the stack.
…en different numbers of logs
…of transaction logs because of forced recoveries
…ges of empty versions
… will become after changing the number of txs tags
Merged
# Conflicts: # fdbserver/TagPartitionedLogSystem.actor.cpp
vishesh reviewed Jul 10, 2019
| localSets.push_back(log); | ||
| if(log->locality == tagLocalitySatellite) { | ||
| bestSatelliteSet = localSets.size() - 1; | ||
| } else { |
Contributor
There was a problem hiding this comment.
Typo s/sattelite/satellite
alexmiller-apple approved these changes Jul 13, 2019
Co-Authored-By: Alex Miller <35046903+alexmiller-apple@users.noreply.github.com>
Co-Authored-By: Alex Miller <35046903+alexmiller-apple@users.noreply.github.com>
Co-Authored-By: Alex Miller <35046903+alexmiller-apple@users.noreply.github.com>
Co-Authored-By: Alex Miller <35046903+alexmiller-apple@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR still has some correctness problems that need to be fixed.