Skip to content

fdbkubernetesmonitor: Add a check for new binaries in the shared binary directory and report them back in an annotation #12230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
johscheuer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fdbkubernetesmonitor: Add a check for new binaries in the shared binary directory and report them back in an annotation #12230

johscheuer wants to merge 1 commit into from
+143 −10

Conversation

@johscheuer
Copy link
Contributor

@johscheuer johscheuer commented Jul 10, 2025

Those changes allow the operator to validate that the binaries are present before triggering a restart.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)
@johscheuer
fdbkubernetesmonitor: Add a check for new binaries in the shared bina…
0fc6263 
…ry directory and report them back in an annotation
@johscheuer johscheuer requested a review from brownleej July 10, 2025 16:17
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 10, 2025

Result of foundationdb-pr-clang-ide on Linux RHEL 9

  • Commit ID: 0fc6263
  • Duration 0:24:06
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 10, 2025

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: 0fc6263
  • Duration 0:34:13
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 10, 2025

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 0fc6263
  • Duration 0:38:58
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 10, 2025

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: 0fc6263
  • Duration 0:40:26
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 10, 2025

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: 0fc6263
  • Duration 0:41:11
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 10, 2025

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: 0fc6263
  • Duration 0:44:33
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
saintstack
saintstack reviewed Aug 19, 2025
View reviewed changes
Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. How'd you test?
fdbkubernetesmonitor/kubernetes.go
return err
}

return podClient.updateAnnotationsOnPod(map[string]string{
Copy link
Contributor

@saintstack saintstack Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does a replace I presume?
fdbkubernetesmonitor/monitor.go
for len(fdbserverBinaries) == 0 {
// If after 5 minutes the new fdbserver binary was not copied, something is probably wrong.
if time.Since(startTime) > 5*time.Minute {
return fmt.Errorf("could not find fdbserver binary in shared binary dir after more than 2 minutes")
Copy link
Contributor

@saintstack saintstack Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/2/5/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@johscheuer @foundationdb-ci @saintstack