Move android commands to android package #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| You should add the package scope in https://github.com/appium/python-client/blob/master/setup.py#L38-L42 to include them in a package |
ki4070ma commented May 11, 2019
setup.py Outdated
| 'appium.webdriver.common', | ||
| 'appium.webdriver.extensions' | ||
| ], | ||
| packages=find_packages(exclude=['test*', 'script*']), |
There was a problem hiding this comment.
Verified in local as below and python setup.py install.
➜ python-client git:(order-commands) ✗ python3 >>> from setuptools import find_packages >>> find_packages(exclude=['test*', 'script*']) ['appium', 'appium.common', 'appium.webdriver', 'appium.webdriver.extensions', 'appium.webdriver.common', 'appium.webdriver.extensions.android'] ➜ python-client git:(order-commands) ✗ python2 >>> from setuptools import find_packages >>> find_packages(exclude=['test*', 'script*']) ['appium', 'appium.common', 'appium.webdriver', 'appium.webdriver.extensions', 'appium.webdriver.common', 'appium.webdriver.extensions.android'] 
KazuCocoa approved these changes May 12, 2019
| author_email='isaac@saucelabs.com', | ||
| url='http://appium.io/', | ||
| packages=find_packages(exclude=['test*', 'script*']), | ||
| packages=find_packages(include=['appium*']), |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reorder mobilecommands
It would be easy to check api overview
Refer to https://github.com/appium/ruby_lib_core/blob/fd2cbde5466a144ce8dccfc6cf330b969bcc8fd3/lib/appium_lib_core/common/command/common.rb
Verified no missing api after reorder
Notice
Have to fix package for constants (e.g. Power.AC_OFF, GsmCallActions) before next release and take care of it after release