Skip to content

#567 fix #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2017
Merged

#567 fix #568

merged 1 commit into from
Feb 13, 2017

Conversation

TikhomirovSergey
Copy link
Contributor

@TikhomirovSergey TikhomirovSergey commented Feb 10, 2017 •
edited
Loading

Change list

#567 fix

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

  • 'isBrowserMethod' is not implemented by default;
  • element generaration was reverted to the old rule which was used before 5.0.0-BETA1
@TikhomirovSergey TikhomirovSergey self-assigned this Feb 10, 2017
@TikhomirovSergey TikhomirovSergey added this to the 5.0.0 milestone Feb 10, 2017
@TikhomirovSergey
Copy link
Contributor Author

@amedvedjev @derunewige
You are invided to review/try this PR too.
If everything is ok then it will be published immideately at the BETA3.

PS. Appium field decorator was changed a little bit. It is not the breaking change... bit it is starting of the refactoring. It is related to the feature request opened by @amedvedjev. It is supposed to be finished at the BETA4.
@amedvedjev
Copy link

@TikhomirovSergey can you give advice how i can try this pull with mine maven project easily?
@TikhomirovSergey TikhomirovSergey merged commit 3d18252 into appium:master Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug

3 participants

@TikhomirovSergey @amedvedjev @SrinivasanTarget