The addition to #513 #514
Merged
The addition to #513 #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ouchActionSplitting
…arget/java-client into SrinivasanTarget-TouchActionSplitting
- new interfaces were added - deprecated API
- new methods were added to MultiTouchAction - AppiumDriver methods which perform multiple touch actions were marked as Deprecated - Constructors of TouchAction and MultiTouchAction were changed. Now it accepts any instance that can perform touch action and multiple touch actions.
- the new interface CreatesSwipeAction was added. - the reversion of last changes of TouchableElement. - the `swipe` is deprecated method.
- CreatesSwipeAction API was implemented - SwipeElementDirection was redesigned - constructors of TouchAction and MultiTouchAction were improved.
- also code issues were got fixed
- IOSSwipeGestureTest was added
- the swiping combined with the tapping.
…b.com/TikhomirovSergey/java-client into TikhomirovSergey-SrinivasanTarget-TouchActionSplitting
Fixed Codacy errors Fixed Codacy errors
| @SrinivasanTarget for iOS? |
| Sure @TikhomirovSergey |
…ikhomirovSergey-SrinivasanTarget-TouchActionSplitting
| @TikhomirovSergey Will complete this tomorrow. Sorry for the delay. |
TikhomirovSergey suggested changes Nov 23, 2016
| @Override | ||
| public TouchAction swipe(int startX, int startY, int endX, int endY, int duration) { | ||
| int xOffset = endX - startX; | ||
| int yOffset = endY - startX; |
TikhomirovSergey approved these changes Nov 23, 2016
Fixed tests Fixed tests Fixed tests
| @TikhomirovSergey Thanks. All tests passed now. |
SrinivasanTarget deleted the TikhomirovSergey-SrinivasanTarget-TouchActionSplitting branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Change list
Addition to #513.
IOSSwipeGestureTestis updated.Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
@TikhomirovSergey FYI