Skip to content

Conversation

truebit
Copy link
Contributor

@truebit truebit commented Jun 8, 2016

Change list

This is a sub PR for appium/appium#6561

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

This is a sub PR for appium/appium#6561

@SrinivasanTarget
Copy link
Member

SrinivasanTarget commented Jun 8, 2016

@truebit Can you please add some tests to this? May be once after your server PR's are merged.

@TikhomirovSergey TikhomirovSergey added this to the 4.1.0 milestone Jun 8, 2016
@TikhomirovSergey
Copy link
Contributor

@truebit
This PR is in the conflicted state.

Can you please add some tests and resolve the conflict?

@TikhomirovSergey TikhomirovSergey removed this from the 4.1.0 milestone Aug 4, 2016
@TikhomirovSergey
Copy link
Contributor

@truebit I'm going to close this PR. It is outdated and looks like some overhead.
I'm working on related improvement of setting engine and I will provide your athorship.
Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment