docs: Add v7->v8 migration guide #1542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… into migration_guide
Collaborator
| Is it worth adding some notes regarding this commit: 5063baf? It's more about Selenium changes, but it could save time for users. |
Contributor Author
| I did add some. Feel free to mention more if I forgot something. |
… into migration_guide
valfirst reviewed Nov 1, 2021
docs/v7-to-v8-migration-guide.md Outdated
| [java.time.Duration](https://docs.oracle.com/javase/8/docs/api/java/time/Duration.html) | ||
| class. | ||
| - The current event firing mechanism that Appium java client uses | ||
| has been deprecated in favour of the one that Selenium4 provides |
Collaborator
There was a problem hiding this comment.
Suggested change
| has been deprecated in favour of the one that Selenium4 provides | |
| has been deprecated in favour of the one that Selenium 4 provides |
docs/v7-to-v8-migration-guide.md Outdated
Comment on lines 38 to 39
| is called now `replaceElementValue`; `setValue` has been moved to the driver | ||
| instance and is called now `setElementValue`. |
Collaborator
There was a problem hiding this comment.
Suggested change
| is called now `replaceElementValue`; `setValue` has been moved to the driver | |
| instance and is called now `setElementValue`. | |
| is called now `replaceElementValue`; `setValue` is replaced with `sendKeys`. |
docs/v7-to-v8-migration-guide.md Outdated
Comment on lines 49 to 50
| [AppiumBy](TBD) | ||
| instead. |
Collaborator
There was a problem hiding this comment.
is it expected to be added something instead of TBD?
Suggested change
| [AppiumBy](TBD) | |
| instead. | |
| [AppiumBy] instead. |
Contributor Author
There was a problem hiding this comment.
added the link
docs/v7-to-v8-migration-guide.md Outdated
| instead. | ||
| Also, all locator names in `AppiumBy` have been aligned to follow the common | ||
| (camelCase) naming strategy, e.g. `MobileBy.AccessibilityId` was changed | ||
| to `AppiumBy.accessibilityId`. |
Collaborator
There was a problem hiding this comment.
I would also put the note like:
The change made in Selenium 4 broke Appium `class name` selector strategy: `AppiumBy.className` should be used instead of Selenium `By.className` now. 
mykola-mokhnach changed the title valfirst approved these changes Nov 1, 2021
SrinivasanTarget approved these changes Nov 1, 2021
docs/v7-to-v8-migration-guide.md Outdated
| - Removed the obsolete `HasSessionDetails` extensions as it was using legacy | ||
| JWP calls to retrieve session details. | ||
| `MobileBy` class has been deprecated. Consider using | ||
| [AppiumBy](TBD) |
Contributor Author
There was a problem hiding this comment.
this must be already solved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Change list
The document describes main pitfalls of the client codebase migration to a new major version of Appium java client.
Types of changes