fix: Increase the timeout for graceful service termination #1354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
SrinivasanTarget approved these changes May 27, 2020
| | ||
| // This all magic is necessary, because Selenium does not publicly expose | ||
| // process killing timeouts. By default a process is killed forcibly if | ||
| // it does not exit after two seconds, which is in most cases not enough for |
There was a problem hiding this comment.
a process is killed forcibly if it does not exist after two seconds
Interesting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Change list
Selenium lib hardcodes the graceful shutdown timeout to 2 seconds (zero on Windows). This is not enough for Appium to properly shutdown all the drivers and clean up the leftovers.
Types of changes