Skip to content

feat: Add idempotency key to session creation requests #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2020
Merged

feat: Add idempotency key to session creation requests #1327

merged 2 commits into from
Apr 1, 2020

Conversation

mykola-mokhnach
Copy link
Contributor

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

This PR adds a random idempotency key to each session creation request. This is necessary to properly handle HTTP request retries. Read appium/appium-base-driver#400 for more details.
@SrinivasanTarget
Copy link
Member

CI is not happy yet since server-side changes aren't available in beta.
@mykola-mokhnach mykola-mokhnach changed the title feat: Add idempotency key to session creation requests [WIP] feat: Add idempotency key to session creation requests Mar 31, 2020
@mykola-mokhnach
Copy link
Contributor Author

mykola-mokhnach commented Mar 31, 2020 •
edited
Loading

@SrinivasanTarget No, unfortunately this is a bug on the server side that is most likely related to keepAlive option and socket reuse. I'll take care about it and restart the test after the patch is merged
@mykola-mokhnach mykola-mokhnach changed the title [WIP] feat: Add idempotency key to session creation requests feat: Add idempotency key to session creation requests Apr 1, 2020
@mykola-mokhnach mykola-mokhnach merged commit 5d6cf9d into appium:master Apr 1, 2020
@mykola-mokhnach mykola-mokhnach deleted the idemp branch April 1, 2020 09:22
@mykola-mokhnach
Copy link
Contributor Author

All works with the recent base driver patch.

cc @KazuCocoa
@KazuCocoa KazuCocoa mentioned this pull request Apr 1, 2020
Merged
This was referenced Apr 2, 2020
Closed
Closed
@mykola-mokhnach mykola-mokhnach mentioned this pull request Apr 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@mykola-mokhnach @SrinivasanTarget @KazuCocoa