-  
-   Notifications  You must be signed in to change notification settings 
- Fork 768
implement driver options #1319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
   Closed  
     Closed  
 implement driver options #1319
Changes from all commits
 Commits 
  Show all changes 
  22 commits   Select commit Hold shift + click to select a range 
 6ecd988  implement driver options 
  titusfortner 0bb2633  add javadocs to mobile options 
  titusfortner e8f4cfd  allow MobileOptions to be instantiated 
  titusfortner 9ce12fd  make requested changes 
  titusfortner 59940a9  implement android options with tests 
  titusfortner 3f08c47  support enums for applicable setters 
  titusfortner 7a626af  add javadocs to android mobile options 
  titusfortner 6642232  fix duration parameters to store correct units in capabilities 
  titusfortner e38f7e1  fix incorrect constants 
  titusfortner d11428b  user needs to be able to pass in int to capability and have it handle… 
  titusfortner c5fbb3d  all ports as Integers 
  titusfortner aefbb79  fix port tests 
  titusfortner d07e5a9  finally fix duration implementation 
  titusfortner 988ac1b  chromedriver ports can have nested lists 
  titusfortner 442a779  Selenium automatically converts ChromeOptions to goog:chromeOptions 
  titusfortner f240eaf  remove unicodeKeyboard accessors 
  titusfortner 1453a1a  change uninstallOtherApps from List to String 
  titusfortner 1df2efd  change otherApps from List to String 
  titusfortner 38b3ef0  fix test 
  titusfortner ffd26c4  fix parameter name 
  titusfortner 3b1c230  don't need to use Object when return value is a List 
  titusfortner 4aa554c  fix ios options test 
  titusfortner File filter
Filter by extension
Conversations
 Failed to load comments.  
    Loading  
 Jump to
  Jump to file  
  Failed to load files.  
    Loading  
 Diff view
Diff view
There are no files selected for viewing
       1,733 changes: 1,733 additions & 0 deletions  1,733   src/main/java/io/appium/java_client/android/AndroidMobileOptions.java          
  Large diffs are not rendered by default.
  Oops, something went wrong.  
    This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters   
     | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| package io.appium.java_client.android; | ||
|  | ||
| public enum UnlockType { | ||
| PIN, PASSWORD, PATTERN, FINGERPRINT | ||
| } | 
       32 changes: 32 additions & 0 deletions  32   src/main/java/io/appium/java_client/ios/IOSMobileOptions.java          
     This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters   
     | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * See the NOTICE file distributed with this work for additional | ||
| * information regarding copyright ownership. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|  | ||
| package io.appium.java_client.ios; | ||
|  | ||
| import io.appium.java_client.remote.MobileOptions; | ||
| import io.appium.java_client.remote.MobilePlatform; | ||
| import org.openqa.selenium.Capabilities; | ||
|  | ||
| public class IOSMobileOptions extends MobileOptions<IOSMobileOptions> { | ||
| public IOSMobileOptions() { | ||
| setPlatformName(MobilePlatform.IOS); | ||
| } | ||
|  | ||
| public IOSMobileOptions(Capabilities source) { | ||
| this(); | ||
| merge(source); | ||
| } | ||
| } | 
   This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters   
       Oops, something went wrong.  
  Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.    
 
Uh oh!
There was an error while loading. Please reload this page.