Skip to content

Conversation

mykola-mokhnach
Copy link
Contributor

Change list

Based on appium/appium-base-driver#328

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@SrinivasanTarget SrinivasanTarget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mykola-mokhnach Checkstyle isn't happy. Also good to have some tests with WDIO. Otherwise good to me.

@mykola-mokhnach mykola-mokhnach merged commit f8982af into appium:master Jun 28, 2019
@mykola-mokhnach mykola-mokhnach deleted the add_execute branch June 28, 2019 18:58
Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 @SrinivasanTarget what will it take to get a publish :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants