[icxtunnel] establish redundant connections to relays #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dilyevsky approved these changes Sep 17, 2025
| For the kube token scenario maybe we can have a single kube api call to get the initial relay addresses and tunnel token up front and then fall back to the same discovery mechanism as not kube api. Yes i like this idea …On Wed, Sep 24, 2025 at 1:16 AM Damian Peckett ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pkg/cmd/alpha/tunnel.go <#64 (comment)>: > @@ -41,6 +45,11 @@ var tunnelRunCmd = &cobra.Command{ Short: "Run a tunnel", Long: "Create a secure tunnel to the remote Apoxy Edge fabric.", RunE: func(cmd *cobra.Command, args []string) error { + if len(relayAddrs) == 0 { I think there's really two scenarios for using the tunnel, one where you're on say lambda and you automatically have a kubernetes service account token you can use for querying the kube API, and a scenario where you don't (eg. on third party infrastructure etc). I'm going to add support for using hostnames for relay addresses (so theoretically the first relay could have a fixed known name). For the kube token scenario maybe we can have a single kube api call to get the initial relay addresses and tunnel token up front and then fall back to the same discovery mechanism as not kube api. — Reply to this email directly, view it on GitHub <#64 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAF3KAFFVFKMM657NYAZ5YL3UJHMLAVCNFSM6AAAAACGVL4JA6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENRRGY3TINZWGM> . You are receiving this because your review was requested.Message ID: ***@***.***> |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Plus fix some bifurcation issues.
Also added some slog based debugging for QUIC.
Right now for each relay address provided we attempt to establish a connection/virtual network. We don't really need multiple "connections" per relay as ICX is connectionless.
There's still an outstanding todo to create a kind of packetconn multiplexer for multiple QUIC clients (so that they can all share the same local udp port with icx data plane).