feat: Add mcp-session-id header to HTTP request trace attributes #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 5 changed, 0 removedBuild ID: e958578b4f8d6bcab5e0eba2 URL: https://www.apollographql.com/docs/deploy-preview/e958578b4f8d6bcab5e0eba2 |
DaleSeo reviewed Oct 7, 2025
There was a problem hiding this comment.
Thanks, @swcollard, for taking care of this nice-to-have that we discussed!
DaleSeo reviewed Oct 7, 2025
| raw_operation = "Graphql operation text and metadata used for Tool generation" | ||
| client_name = "The client name that initializes with the MCP Server" | ||
| client_version = "The client version that initializes with the MCP Server" | ||
| session_id = "The value of the Mcp-Session-Id header in the HTTP request" |
There was a problem hiding this comment.
Because the mcp-session-id header is present on both request and response, can we add trace attributes for both, so we can correlate end-to-end?
swcollard force-pushed the trace-session-id branch from 73e404c to 65b6ba9 Compare DaleSeo approved these changes Oct 8, 2025
Comment on lines +237 to +243
| if let Some(session_id) = response | ||
| .headers() | ||
| .get("mcp-session-id") | ||
| .and_then(|v| v.to_str().ok()) | ||
| { | ||
| span.record("session_id", tracing::field::display(session_id)); | ||
| } |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR includes the value of the Mcp-Session-Id HTTP header as an attribute of the trace for HTTP requests to the MCP Server