Skip to content

Conversation

guillaume-sainthillier
Copy link
Contributor

@guillaume-sainthillier guillaume-sainthillier commented May 31, 2024

Q A
Branch? 3.2
Tickets #6404
License MIT
Doc PR N/A

Hello, this PR let ReadProvider handle nullable request because RequestParser::getQueryString($request) expects a request object to work.

We had this bug when using provider in CLI during async export of a GetCollection operation

@guillaume-sainthillier guillaume-sainthillier changed the base branch from 3.1 to 3.2 May 31, 2024 14:36
@guillaume-sainthillier guillaume-sainthillier changed the title Fix empty request in read provider fix(state) empty request in read provider May 31, 2024
@guillaume-sainthillier guillaume-sainthillier changed the title fix(state) empty request in read provider fix(state) handle empty request in read provider May 31, 2024
@guillaume-sainthillier guillaume-sainthillier force-pushed the fix-empty-request-in-read-provider branch 2 times, most recently from 3a73834 to 9f2b39b Compare May 31, 2024 14:50
@soyuka
Copy link
Member

soyuka commented May 31, 2024

nice catch, wasn't expecting code to be used like this but I see no reason it wouldn't work :)

let me know if you have more issues, commit message is also missing : after the fix(state)

@guillaume-sainthillier guillaume-sainthillier force-pushed the fix-empty-request-in-read-provider branch from 9f2b39b to 3637799 Compare May 31, 2024 15:28
@guillaume-sainthillier
Copy link
Contributor Author

guillaume-sainthillier commented May 31, 2024

nice catch, wasn't expecting code to be used like this but I see no reason it wouldn't work :)

let me know if you have more issues, commit message is also missing : after the fix(state)

Thank you for quick review!
Indeed we do serialize query filters before turning on async mode, so no request is present :-)

@soyuka soyuka merged commit 99314bf into api-platform:3.2 Jun 3, 2024
@guillaume-sainthillier guillaume-sainthillier deleted the fix-empty-request-in-read-provider branch January 31, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants