fix: missing eager joins on to-one relationships #5992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| nice, can you target 3.1? |
MariusJam force-pushed the fix/missing-eager-join branch from f70e42f to 8d29083 Compare | It's done |
| thanks @MariusJam |
| Hi, it happens I have a few tests in error with your patch, I reverted but I think it'd still be a good patch if you can take another look (ci is green at #6000) |
MariusJam added a commit to MariusJam/core that referenced this pull request Nov 27, 2023
…-platform#5992)"" This reverts commit dac49cb.
MariusJam added a commit to MariusJam/core that referenced this pull request Nov 28, 2023
…-platform#5992)"" This reverts commit dac49cb.
MariusJam added a commit to MariusJam/core that referenced this pull request Nov 28, 2023
…-platform#5992)"" This reverts commit dac49cb.
soyuka pushed a commit that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In some cases, the EagerLoadingExtension misses some joins it should normally load eagerly. This happens when a *ToOne relationship shares the same inversedBy name than in the parent class. This PR aims to solve this problem and correctly eager join all to-one relationships than should be eager joined.