fix(serializer): retrieve only first uriVariable from operation #5788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
romainallanot commented Aug 30, 2023
romainallanot commented | Q | A |
|---|---|
| Branch? | 3.1 |
| Tickets | #5736 |
| License | MIT |
| Doc PR | N/A |
romainallanot force-pushed the issue-5736 branch 2 times, most recently from e014697 to c0fa58b Compare 
romainallanot force-pushed the issue-5736 branch from c0fa58b to 4dc9c91 Compare 
soyuka reviewed Aug 31, 2023
soyuka reviewed Aug 31, 2023
| $this->assertInstanceOf(Dummy::class, $normalizer->denormalize(['id' => '/dummies/12', 'name' => 'hello'], Dummy::class, null, $context)); | ||
| } | ||
| | ||
| public function testDenormalizeGuessingUriVariables(): void |
There was a problem hiding this comment.
this is wrong and can not work in a real case scenario so we remove it
Romaixn pushed a commit to Romaixn/core that referenced this pull request Oct 3, 2023
…platform#5788) * fix(serializer): retrieve only first uriVariable from operation * array default --------- Co-authored-by: Antoine Bluchet <soyuka@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.