fix: securityPostDenormalize not working because clone is made after denormalization #5182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Would it be possible to have a non regression test? |
| nice catch thanks @LoicBoursin ! |
| Thanks for the fix. For anyone still having issues, check your allow_if_all_abstain and strategy security setting: security: access_decision_manager: strategy: priority allow_if_all_abstain: true If I have allow_if_all_abstain set to false in my project, one of my voters will produce a false positive of sorts in the Symfony profiler. This is even when the voter's supports() returns false, or voteOnAttribute() returns true. |
| @FPDK thanks for that, do you think it could be added to the api platform documentation? |
| @soyuka If I can find the time, I'll try to test it in a blank project first before I create a PR on the docs :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Support for
security_post_denormalizewas added in #4184.At that moment, the clone to populate previousObject was made before denormalization. It worked well.
This commit moved the clone after denormalization.
After upgrading to 3.0, using
security_post_denormalizeon a anApiPropertywas not working anymore. Moving the$previousObjectline to its first position fixed the issue on my project.I believe this issue will be fixed too.