Add github workflow for tests on PostGIS 3.2 #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sharkAndshark changed the title 
apdevelop reviewed Sep 3, 2022
| /// <param name="geometry">Input geometry.</param> | ||
| /// <returns>Geometry type string (with 'ST_' prefix).</returns> | ||
| [Sql.Function("ST_GeometryType", ServerSideOnly = true)] | ||
| [Sql.Expression("ST_GeometryType({0}::geometry)", ServerSideOnly = true)] |
There was a problem hiding this comment.
"ST_GeometryType({0}::geometry)"
Could be a better approach than 9fdcaae workaround with version check... will it work in PostGIS 2.5 ?
There was a problem hiding this comment.
Works on my machine.
apdevelop reviewed Sep 3, 2022
| { | ||
| const string Wkt1 = "LINESTRING(0 1, 0 2)"; | ||
| db.TestGeometries.Value(g => g.Id, 1).Value(g => g.Geometry, () => GeometryInput.STGeomFromText(Wkt1)).Insert(); | ||
| const string wkt1 = "LINESTRING(0 1, 0 2)"; |
There was a problem hiding this comment.
The recommended naming and capitalization convention for constants is to use PascalCasing for constants
sharkAndshark force-pushed the tests_on_3.2 branch from 3c1894c to ef51f5a Compare 
sharkAndshark force-pushed the tests_on_3.2 branch from ef51f5a to c996da1 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.