Skip to content

Bugfix for 66104 - Check for the existence of the log directory before executing the cleanup task at startup #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Bugfix for 66104 - Check for the existence of the log directory before executing the cleanup task at startup #521

wants to merge 1 commit into from

Conversation

@aooohan
Copy link
Member

@aooohan aooohan commented Jun 5, 2022 •
edited
Loading

markt-asf added a commit that referenced this pull request Jun 6, 2022
@markt-asf
Don't try and clean directory that doesn't exists + refactoring
8ffc799 
Avoid error message by not trying to clean up old files from the logging directory before the directory has been created. Based on #521 by HanLi. Refactor obtaining Path for a given directory
markt-asf added a commit that referenced this pull request Jun 6, 2022
@markt-asf
Don't try and clean directory that doesn't exists + refactoring
58eb860 
Avoid error message by not trying to clean up old files from the logging directory before the directory has been created. Based on #521 by HanLi. Refactor obtaining Path for a given directory
markt-asf added a commit that referenced this pull request Jun 6, 2022
@markt-asf
Don't try and clean directory that doesn't exists + refactoring
9520015 
Avoid error message by not trying to clean up old files from the logging directory before the directory has been created. Based on #521 by HanLi. Refactor obtaining Path for a given directory
markt-asf added a commit that referenced this pull request Jun 6, 2022
@markt-asf
Don't try and clean directory that doesn't exists + refactoring
4404410 
Avoid error message by not trying to clean up old files from the logging directory before the directory has been created. Based on #521 by HanLi. Refactor obtaining Path for a given directory
@markt-asf
Copy link
Contributor

Thanks for the bug report and the PR.

I applied this manually so I could:

  • refactor this code and the other location that obtains a Path from the directory
  • used a Java 7+ compatible approach that could be back-ported and then changed this to the Java 11+ approach
  • add a changelog entry
@markt-asf markt-asf closed this Jun 6, 2022
@aooohan aooohan deleted the fixbug_66104 branch June 6, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@aooohan @markt-asf