[SPARK-47636][K8S][3.5] Use Java 17 instead of 17-jre image in K8s Dockerfile #45762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dongjoon-hyun changed the title 17 instead of 17-jre image in K8s Dockerfile 
Member Author
| cc @viirya |
viirya approved these changes Mar 28, 2024
Member Author
| Thank you, @viirya ! |
dongjoon-hyun added a commit that referenced this pull request Mar 28, 2024
…s Dockerfile ### What changes were proposed in this pull request? This PR aims to use Java 21 instead of 21-jre in K8s Dockerfile . ### Why are the changes needed? Since Apache Spark 3.5.0, SPARK-44153 starts to use `jmap` like the following. https://github.com/apache/spark/blob/c832e2ac1d04668c77493577662c639785808657/core/src/main/scala/org/apache/spark/util/Utils.scala#L2030 ``` $ docker run -it --rm eclipse-temurin:17-jre jmap /__cacert_entrypoint.sh: line 30: exec: jmap: not found ``` ``` $ docker run -it --rm eclipse-temurin:17 jmap | head -n2 Usage: jmap -clstats <pid> ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs and manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45762 from dongjoon-hyun/SPARK-47636. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Member Author
| Merged to branch-3.5 for Apache Spark 3.5.2. |
szehon-ho pushed a commit to szehon-ho/spark that referenced this pull request Aug 7, 2024
…s Dockerfile ### What changes were proposed in this pull request? This PR aims to use Java 21 instead of 21-jre in K8s Dockerfile . ### Why are the changes needed? Since Apache Spark 3.5.0, SPARK-44153 starts to use `jmap` like the following. https://github.com/apache/spark/blob/c832e2ac1d04668c77493577662c639785808657/core/src/main/scala/org/apache/spark/util/Utils.scala#L2030 ``` $ docker run -it --rm eclipse-temurin:17-jre jmap /__cacert_entrypoint.sh: line 30: exec: jmap: not found ``` ``` $ docker run -it --rm eclipse-temurin:17 jmap | head -n2 Usage: jmap -clstats <pid> ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs and manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45762 from dongjoon-hyun/SPARK-47636. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dongjoon-hyun added a commit to apache/spark-docker that referenced this pull request Sep 18, 2024
### What changes were proposed in this pull request? This PR aims to use JDK for Spark 3.5+ Docker image. Apache Spark Dockerfile are updated already. - apache/spark#45762 - apache/spark#45761 ### Why are the changes needed? Since Apache Spark 3.5.0, SPARK-44153 starts to use `jmap` like the following. - apache/spark#41709 https://github.com/apache/spark/blob/c832e2ac1d04668c77493577662c639785808657/core/src/main/scala/org/apache/spark/util/Utils.scala#L2030 ### Does this PR introduce _any_ user-facing change? Yes, the user can use `Heap Histogram` feature. ### How was this patch tested? Pass the CIs. Closes #66 from dongjoon-hyun/SPARK-49701. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use Java 21 instead of 21-jre in K8s Dockerfile .
Why are the changes needed?
Since Apache Spark 3.5.0, SPARK-44153 starts to use
jmaplike the following.spark/core/src/main/scala/org/apache/spark/util/Utils.scala
Line 2030 in c832e2a
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs and manual review.
Was this patch authored or co-authored using generative AI tooling?
No.