Skip to content

Conversation

@lizhimins
Copy link
Member

Which Issue(s) This PR Fixes

Fixes #9921

Brief Description

How Did You Test This Change?

Copy link
Contributor

@qianye1001 qianye1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.80%. Comparing base (beee84f) to head (8849499).

Files with missing lines Patch % Lines
...apache/rocketmq/broker/pop/PopConsumerService.java 66.66% 3 Missing ⚠️
.../java/org/apache/rocketmq/common/BrokerConfig.java 25.00% 3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## develop #9922 +/- ## ============================================= - Coverage 48.83% 48.80% -0.04%  + Complexity 12751 12743 -8  ============================================= Files 1324 1324 Lines 96288 96299 +11 Branches 12409 12409 ============================================= - Hits 47023 46995 -28  - Misses 43517 43556 +39  Partials 5748 5748 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@humkum
Copy link
Contributor

humkum commented Dec 15, 2025

这个改动是为了减少 CPU 压力吗?最近我们发现 pop 消费在 revive 执行时单核占用有打满的情况

@lizhimins
Copy link
Member Author

lizhimins commented Dec 18, 2025

这个改动是为了减少 CPU 压力吗?最近我们发现 pop 消费在 revive 执行时单核占用有打满的情况

在队列版的 Pop 实现上,revive 压力会被分摊到 8 个线程上。
看下是不是这个 #9812 问题,确认是 revive 导致的吗?
这个提交是在冷读到分级存储时限制一下读取的内存使用。

@lizhimins lizhimins merged commit 6fa05ff into apache:develop Dec 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants