Skip to content

Conversation

@davidkhala
Copy link
Contributor

exclude unnecessary files to be included in npm package

A small PR without linked to any issue

Motivation

After I investigate the node_modules I get via npm install, I see some source files leakage as redundency to end user

Modifications

Via this change, the folder tests/ and .github will be exluded in next npm publish release

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • doc-not-needed
exclude unnecessary files to be included in npm package
@shibd shibd added this to the 1.14.0 milestone Jun 11, 2025
@shibd
Copy link
Member

shibd commented Jun 11, 2025

Hi, @davidkhala should add license to .npmignore, or ignore it.

Using ignore file ✗ License not found in .npmignore License check failed. 1 file(s) did not have the license. Command failed 
@davidkhala
Copy link
Contributor Author

@shibd does it look good now?

@shibd shibd merged commit a2983fc into apache:master Jun 19, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants