Skip to content

Conversation

@shibd
Copy link
Member

@shibd shibd commented Feb 20, 2025

Modifications

  1. Change upload-artifact to v4: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
  2. Rewrite the download script: because original will get error, details rerfer to: https://github.com/orgs/community/discussions/88698

Verifying this change

  • verify it when released 1.13

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@shibd shibd self-assigned this Feb 20, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get what the actual changes here. Could you explain more?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main change is use requests instead of urllib.request

@shibd shibd requested a review from RobertIndie February 20, 2025 09:15
@shibd shibd merged commit 36b154e into apache:master Feb 26, 2025
12 checks passed
@lukehedger
Copy link

@shibd Do you know when the v1.13 release will be retried?

@shibd
Copy link
Member Author

shibd commented Feb 28, 2025

@shibd Do you know when the v1.13 release will be retried?

It inprogress releas, you can try it:

npm i pulsar-client@1.13.0-rc.2 --pulsar_binary_host_mirror=https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-node/ 
shibd added a commit that referenced this pull request Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants