Generate and install pulsarStaticWithDeps into correct paths #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
### Motivation Currently, the `pulsarStaticWithDeps` target (`libpulsarwithdeps.a`) is generated under the `./lib` directory relative to the project root path. However, if the cmake build directory is customized, e.g. `cmake -B build`, the `libpulsarwithdeps.a` is still generated under `lib/`, not `build/lib`. In addition, the install target doesn't install the `libpulsarwithdeps.a` except for MSVC build. ### Modification Modify the `lib/CMakeLists.txt` to: - generate `libpulsarwithdeps.a` under the CMake build directory - add `libpulsarwithdeps.a` to the install target ### Verification Run the following commands: ```bash cmake -DLINK_STATIC=ON -DCMAKE_INSTALL_PREFIX=/tmp/pulsar-cpp -B build cmake --build build --target install ``` We can see the following files generated and installed: ```bash $ ls -1 build/lib/libpulsar* build/lib/libpulsar.a build/lib/libpulsar.dylib build/lib/libpulsarnossl.dylib build/lib/libpulsarwithdeps.a $ ls -1 /tmp/pulsar-cpp/lib libpulsar.a libpulsar.dylib libpulsarnossl.dylib libpulsarwithdeps.a ```
BewareMyPower requested review from Demogorgon314, RobertIndie, merlimat and nodece 
merlimat approved these changes Oct 8, 2022
Demogorgon314 approved these changes Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the
pulsarStaticWithDepstarget (libpulsarwithdeps.a) is generated under the./libdirectory relative to the project root path. However, if the cmake build directory is customized, e.g.cmake -B build, thelibpulsarwithdeps.ais still generated underlib/, notbuild/lib.In addition, the install target doesn't install the
libpulsarwithdeps.aexcept for MSVC build.Modification
Modify the
lib/CMakeLists.txtto:libpulsarwithdeps.aunder the CMake build directorylibpulsarwithdeps.ato the install targetVerification
Run the following commands:
We can see the following files generated and installed:
$ ls -1 build/lib/libpulsar* build/lib/libpulsar.a build/lib/libpulsar.dylib build/lib/libpulsarnossl.dylib build/lib/libpulsarwithdeps.a $ ls -1 /tmp/pulsar-cpp/lib libpulsar.a libpulsar.dylib libpulsarnossl.dylib libpulsarwithdeps.aDocumentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)