Two more test cases for multi-release integration tests #951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| @desruisseaux what do you think? |
Contributor
| Yes, more test cases are good. Launching the workflow. |
src/it/multirelease-patterns/singleproject-separate-moduleinfo/pom.xml Outdated Show resolved Hide resolved
…lt in a separate execution Moreover the version 9 multirelease directory contains a class that is not in the base directory and that should be still accessible to the version 17 multirelease classes
| @desruisseaux Please assign appropriate label to PR according to the type of change. |
desruisseaux added maintenance hacktoberfest-accepted and removed hacktoberfest-accepted labels Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
These two test cases helped us to detect errors while building multi-release jars with different module-info.java positions. Would be good to add them to the integration tests so that we don't regress.