Add reachability-metadata.json to all Log4j modules #3053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This PR adds a plugin processor that generates a GraalVM reachability metadata file and bundles it with each Log4j module. After this change, GraalVM will be able to handle Log4j Core without any user intervention. **Note**: I also added a static `resource-config.json` file that specifies that all resources starting with `log4j2` and the plugin descriptor must be included in the GraalVM image.
vy requested changes Oct 3, 2024
...c/test/java/org/apache/logging/log4j/core/config/plugins/processor/GraalVmProcessorTest.java Outdated Show resolved Hide resolved
...c/test/java/org/apache/logging/log4j/core/config/plugins/processor/GraalVmProcessorTest.java Outdated Show resolved Hide resolved
...e/src/main/java/org/apache/logging/log4j/core/config/plugins/processor/GraalVmProcessor.java Outdated Show resolved Hide resolved
...e/src/main/java/org/apache/logging/log4j/core/config/plugins/processor/GraalVmProcessor.java Outdated Show resolved Hide resolved
...e/src/main/java/org/apache/logging/log4j/core/config/plugins/processor/GraalVmProcessor.java Outdated Show resolved Hide resolved
...e/src/main/java/org/apache/logging/log4j/core/config/plugins/processor/GraalVmProcessor.java Outdated Show resolved Hide resolved
...va/org/apache/logging/log4j/core/config/plugins/processor/internal/ReachabilityMetadata.java Outdated Show resolved Hide resolved
...va/org/apache/logging/log4j/core/config/plugins/processor/internal/ReachabilityMetadata.java Outdated Show resolved Hide resolved
...ain/resources/META-INF/native-image/org.apache.logging.log4j/log4j-core/resource-config.json Show resolved Hide resolved
2 tasks
Simplifies `ReachabilityMetadata` and fixes unclosed resource.
Add a GraalVM metadata file to include the following 3 files into an executable: * `log4j2.component.properties`, * `log4j2.simplelog.properties`, * `log4j2.StatusLogger.properties`
vy approved these changes Oct 4, 2024
This was referenced Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds a plugin processor that generates a GraalVM reachability metadata file and bundles it with each Log4j module.
After this change, GraalVM will be able to handle Log4j Core without any user intervention.
Note: I also added a static
resource-config.jsonfile that specifies that all resources starting withlog4j2and the plugin descriptor must be included in the GraalVM image.Part of #2831.