Skip to content

Conversation

vy
Copy link
Member

@vy vy commented Oct 1, 2024

This work is a follow-up of #2691 and implements the following changes:

  1. Exception converters ensures a newline prefix (which used to be a whitespace)
  2. Fix property extraction for root exceptions (e.g., %rEx{short.className})
@vy vy added the layouts Affects one or more Layout plugins label Oct 1, 2024
@vy vy added this to the 2.25.0 milestone Oct 1, 2024
@vy vy marked this pull request as draft October 1, 2024 20:10
Copy link

github-actions bot commented Oct 1, 2024

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 Build Scan PUBLISHED
Generated by gradle/develocity-actions
@vy vy requested a review from ppkarwasz October 7, 2024 09:40
@vy vy changed the title Suffix pattern with %n%xEx in Pattern Layout Prefix stack traces with a newline in Pattern Layout Oct 7, 2024
@vy vy self-assigned this Oct 7, 2024
@vy vy marked this pull request as ready for review October 7, 2024 10:54
Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 💯

I didn't check everything in details, but we could profit from the rewrite to modernize a little bit how our tests run.

@vy vy merged commit 1e154d4 into apache:2.x Oct 9, 2024
9 checks passed
vy added a commit that referenced this pull request Oct 9, 2024
- Exception converters are reworked to ensure a newline prefix (which used to be a whitespace) - Fix property extraction for root exceptions (e.g., %rEx{short.className}) Co-authored-by: AlanYu <alan0428a@gmail.com> Co-authored-by: Piotr P. Karwasz <piotr@github.copernik.eu>
vy added a commit that referenced this pull request Oct 10, 2024
- Exception converters are reworked to ensure a newline prefix (which used to be a whitespace) - Fix property extraction for root exceptions (e.g., %rEx{short.className}) - Ports #3045 Co-authored-by: AlanYu <alan0428a@gmail.com> Co-authored-by: Piotr P. Karwasz <piotr@github.copernik.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

layouts Affects one or more Layout plugins

3 participants