-
- Notifications
You must be signed in to change notification settings - Fork 1.7k
Google OSS-Fuzz integration #2949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`only-script` is the new default type and it supports `MAVEN_ARGS`
ppkarwasz requested changes Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 💯
I only have some minor remarks on this huge PR:
log4j-fuzz-test/src/main/java/org/apache/logging/log4j/fuzz/FuzzingUtil.java Outdated Show resolved Hide resolved
log4j-fuzz-test/src/main/java/org/apache/logging/log4j/fuzz/FuzzingUtil.java Outdated Show resolved Hide resolved
log4j-core-fuzz-test/src/main/java/org/apache/logging/log4j/core/fuzz/PatternLayoutFuzzer.java Outdated Show resolved Hide resolved
...c/main/java/org/apache/logging/log4j/layout/template/json/fuzz/JsonTemplateLayoutFuzzer.java Show resolved Hide resolved
log4j-slf4j2-impl-fuzz-test/src/main/java/org/apache/logging/slf4j/fuzz/Slf4jLoggerFacade.java Show resolved Hide resolved
Co-authored-by: Piotr P. Karwasz <piotr.github@karwasz.org>
Co-authored-by: Piotr P. Karwasz <piotr.github@karwasz.org>
Co-authored-by: Piotr P. Karwasz <piotr.github@karwasz.org>
Co-authored-by: Piotr P. Karwasz <piotr.github@karwasz.org>
Co-authored-by: Piotr P. Karwasz <piotr.github@karwasz.org>
| @ppkarwasz, what do your FQCN fixes address in the context of fuzzing? |
Probably nothing, I just wanted to give a good example to users, if they apply the code somewhere else. |
ppkarwasz approved these changes Sep 17, 2024
jonathanmetzman pushed a commit to google/oss-fuzz that referenced this pull request Sep 18, 2024
In #12304, we used `fuzzing` branch of the `apache/logging-log4j2` repository while developing the Log4j 2 integration. This work was successful and we eventually merged the `fuzzing` branch to `2.x`<sup>1</sup> in apache/logging-log4j2#2949. Now we can point OSS-Fuzz to the permanent location of the Log4j 2 fuzz tests. <sup>1</sup> [`2.x` is the main branch where Log4j 2 development takes place.](https://logging.apache.org/log4j/2.x/development.html#branching)
vy added a commit that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As a deliverable of #2891 and #2892, implements Google OSS-Fuzz integration. See the added
FUZZING.adocfor details.