Prevent log4j2.isWebapp from overriding other constants #2517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ppkarwasz commented Apr 25, 2024
log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java Outdated Show resolved Hide resolved
Currently, if `log4j2.isWebapp` is enabled, the effective values of the following system properties: * `log4j2.enableThreadlocals`, * `log4j2.garbagefreeThreadLocalMap`, * `log4j2.shutdownHookEnabled`. is set to `false`. After this PR: * the above mentioned constants are set to the value **explicitly** set by the user, * if the user didn't provide any value `!log4j2.isWebapp` is used.
ppkarwasz force-pushed the feature/2.x/change-is-webapp branch from b21ce87 to 644b629 Compare 
vy reviewed Apr 25, 2024
log4j-api/src/main/java/org/apache/logging/log4j/util/Constants.java Outdated Show resolved Hide resolved
log4j-api/src/main/java/org/apache/logging/log4j/util/Constants.java Outdated Show resolved Hide resolved
Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently, if
log4j2.isWebappis enabled, the effective values of the following system properties:log4j2.enableThreadlocals,log4j2.garbagefreeThreadLocalMap,log4j2.shutdownHookEnabled.is set to
false.After this PR:
!log4j2.isWebappis used.