Add trace context fields to GcpLayout.json #2498
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.



This PR adds a few tracing related JSON fields to the included
GcpLayout.jsonevent template which are documented in the Cloud Logging docs.The intended source is well known OpenTelemetry MDC keys encoded as a hex strings following the W3C Trace Context standard.
trace_id->logging.googleapis.com/tracespan_id->logging.googleapis.com/spanIdtrue->logging.googleapis.com/trace_sampled. This is unconditionally set to true because there is currently no way to derive it from W3Ctrace_flagswith JTL (see Can JsonTemplateLayout output JSON boolean values? #2482). I'm OK to remove this if needed, as it will affect existing users even if the MDC keys are not set. However it's absence does break some GCP UI features.