Skip to content

Conversation

@Zony7
Copy link
Contributor

@Zony7 Zony7 commented Aug 27, 2023

we should check the compatibility in:

  • Cassandra Server V3.11
  • Cassandra Server V4.0

Expect to be able to connect the two versions properly?

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Merging #2300 (dd8a858) into master (e90489f) will increase coverage by 6.84%.
The diff coverage is 100.00%.

@@ Coverage Diff @@ ## master #2300 +/- ## ============================================ + Coverage 61.43% 68.28% +6.84%  - Complexity 488 682 +194  ============================================ Files 506 506 Lines 42049 42049 Branches 5827 5827 ============================================ + Hits 25832 28712 +2880  + Misses 13596 10567 -3029  - Partials 2621 2770 +149 
Files Coverage Δ
...raph/backend/store/cassandra/CassandraMetrics.java 85.03% <100.00%> (ø)
...egraph/backend/store/cassandra/CassandraShard.java 55.04% <ø> (+0.91%) ⬆️

... and 97 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

@imbajin imbajin added dependencies Incompatible dependencies of package cassandra Cassandra backend and removed inactive labels Oct 27, 2023
@imbajin imbajin added this to the 1.2.0 milestone Oct 27, 2023
@Zony7 Zony7 marked this pull request as ready for review October 27, 2023 09:18
Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and could enhance Hbase version in next PR maybe (before next release V1.2)

- name: Install JDK 8

TRAVIS_DIR=`dirname $0`
CASS_DOWNLOAD_ADDRESS="http://archive.apache.org/dist/cassandra"
CASS_VERSION="3.10"
CASS_VERSION="4.0.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this PR merged, maybe we could remove useless bundled Java8 env in ci (HBase also need update the version)
image

Hbase Refer: (so we need upgrade to HBase 2.3+ in ci)
img_v2_5fbd54e3-6118-4d32-bfd7-6bd1dbf0b77g

@imbajin imbajin merged commit 70ab14e into apache:master Oct 28, 2023
@imbajin imbajin changed the title feat(cassandra): adapt hugegraph-cassandra from 3.11.12 to 4.0.10 feat(cassandra): adapt cassandra from 3.11.12 to 4.0.10 Oct 28, 2023
VGalaxies pushed a commit to VGalaxies/incubator-hugegraph that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cassandra Cassandra backend dependencies Incompatible dependencies of package

3 participants