Skip to content

Conversation

@qwtsc
Copy link
Contributor

@qwtsc qwtsc commented Aug 14, 2023

Purpose of the PR

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need
@imbajin imbajin requested review from javeme and zyxxoo August 14, 2023 10:22
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.58%. Comparing base (b02c2bd) to head (4862a70).
⚠️ Report is 399 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #2281 +/- ## ============================================ - Coverage 68.63% 68.58% -0.05%  Complexity 977 977 ============================================ Files 498 498 Lines 40684 40685 +1 Branches 5681 5681 ============================================ - Hits 27922 27904 -18  - Misses 10056 10078 +22  + Partials 2706 2703 -3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@qwtsc
Copy link
Contributor Author

qwtsc commented Aug 14, 2023

Force-push note: clean the unused imports

Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@qwtsc qwtsc requested a review from javeme August 19, 2023 07:38
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imbajin imbajin changed the title fix: close flat mapper iterator after usage fix(core): close flat mapper iterator after usage Aug 21, 2023
@imbajin imbajin merged commit aaf67cf into apache:master Aug 29, 2023
DanGuge pushed a commit to DanGuge/incubator-hugegraph that referenced this pull request Sep 25, 2023
close [Bug] FlatMapperIterator should be closed after usage apache#2280
VGalaxies pushed a commit to VGalaxies/incubator-hugegraph that referenced this pull request Nov 10, 2023
close [Bug] FlatMapperIterator should be closed after usage apache#2280
imbajin pushed a commit that referenced this pull request Nov 10, 2023
close [Bug] FlatMapperIterator should be closed after usage #2280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants