Skip to content

Conversation

@liuxiaocs7
Copy link
Member

@liuxiaocs7 liuxiaocs7 commented Dec 7, 2023

Purpose of the PR

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need
@github-actions github-actions bot added the loader hugegraph-loader label Dec 7, 2023
@codecov
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b066b80) 62.49% compared to head (792f8be) 62.47%.
Report is 2 commits behind head on master.

Files Patch % Lines
...egraph/loader/direct/loader/HBaseDirectLoader.java 0.00% 2 Missing ⚠️
.../apache/hugegraph/loader/executor/LoadOptions.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## master #548 +/- ## ============================================ - Coverage 62.49% 62.47% -0.03%  + Complexity 1903 930 -973  ============================================ Files 262 93 -169 Lines 9541 4509 -5032 Branches 886 529 -357 ============================================ - Hits 5963 2817 -3146  + Misses 3190 1483 -1707  + Partials 388 209 -179 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javeme javeme merged commit 1fdc4ef into apache:master Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

loader hugegraph-loader

3 participants