Skip to content

Conversation

@liuxiaocs7
Copy link
Member

@liuxiaocs7 liuxiaocs7 commented Nov 30, 2023

Purpose of the PR

Introduce https://github.com/eirslett/frontend-maven-plugin to install node and yarn automatically when build.

After PR: #542 merged and env prepared, this pr could continue.

update: (note retry) eirslett/frontend-maven-plugin#1098

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need
Comment on lines +71 to +73
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
<version>1.14.2</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need update the LICENSE/NOTICE & 3rd party file maybe?
https://hugegraph.apache.org/docs/contribution-guidelines/contribute/#321-check-licenses

@liuxiaocs7
Copy link
Member Author

liuxiaocs7 commented Nov 30, 2023

Note:

image

Local test success with mvn package -DskipTests

image

image


eirslett/frontend-maven-plugin#743

@codecov
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b066b80) 62.49% compared to head (4ee69ae) 62.46%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #543 +/- ## ============================================ - Coverage 62.49% 62.46% -0.04%  + Complexity 1903 1902 -1  ============================================ Files 262 262 Lines 9541 9533 -8 Branches 886 886 ============================================ - Hits 5963 5955 -8  Misses 3190 3190 Partials 388 388 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simon824
Copy link
Member

simon824 commented Dec 5, 2023

[INFO] Treating warnings as errors because process.env.CI = true. [INFO] Most CI servers set it automatically. [INFO] [INFO] Failed to compile. 

refer to https://stackoverflow.com/questions/60667548/frontend-maven-plugin-fails-to-execute-goal

simon824
simon824 previously approved these changes Dec 5, 2023
imbajin
imbajin previously approved these changes Dec 5, 2023
@liuxiaocs7
Copy link
Member Author

liuxiaocs7 commented Mar 7, 2024

Note, add CI=false && will fail locally in windows

CC: @imbajin and @returnToInnocence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hubble hugegraph-hubble

3 participants