- Notifications
You must be signed in to change notification settings - Fork 44
implement rings-detection algorithm #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
f1923be
to a82db1a
Compare javeme reviewed Aug 26, 2021
...ter-algorithm/src/main/java/com/baidu/hugegraph/computer/algorithm/rings/RingsDetection.java Outdated Show resolved Hide resolved
...lgorithm/src/main/java/com/baidu/hugegraph/computer/algorithm/rings/RingsDetectionValue.java Outdated Show resolved Hide resolved
...lgorithm/src/main/java/com/baidu/hugegraph/computer/algorithm/rings/RingsDetectionValue.java Outdated Show resolved Hide resolved
computer-algorithm/src/main/java/com/baidu/hugegraph/computer/algorithm/rings/SpreadFilter.java Outdated Show resolved Hide resolved
computer-core/src/main/java/com/baidu/hugegraph/computer/core/config/ComputerOptions.java Outdated Show resolved Hide resolved
computer-core/src/main/java/com/baidu/hugegraph/computer/core/config/ComputerOptions.java Outdated Show resolved Hide resolved
computer-core/src/main/java/com/baidu/hugegraph/computer/core/input/DefaultInputFilter.java Show resolved Hide resolved
computer-algorithm/src/main/java/com/baidu/hugegraph/computer/algorithm/rings/SpreadFilter.java Outdated Show resolved Hide resolved
computer-algorithm/src/main/java/com/baidu/hugegraph/computer/algorithm/rings/SpreadFilter.java Outdated Show resolved Hide resolved
coderzc requested changes Aug 26, 2021
8a29d69
to d096016
Compare javeme reviewed Aug 30, 2021
computer-api/src/main/java/com/baidu/hugegraph/computer/core/graph/value/StringValue.java Outdated Show resolved Hide resolved
computer-core/src/main/java/com/baidu/hugegraph/computer/core/config/ComputerOptions.java Outdated Show resolved Hide resolved
javeme reviewed Aug 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also update "cycle detection algorithm" to "implement rings-detection algorithm"
javeme reviewed Aug 30, 2021
...src/main/java/com/baidu/hugegraph/computer/core/input/filter/SaveAllPropertyInputFilter.java Outdated Show resolved Hide resolved
...ter-algorithm/src/main/java/com/baidu/hugegraph/computer/algorithm/rings/RingsDetection.java Outdated Show resolved Hide resolved
1242c55
to 76b445e
Compare javeme reviewed Aug 30, 2021
...er-core/src/main/java/com/baidu/hugegraph/computer/core/input/filter/ExtractAllProperty.java Outdated Show resolved Hide resolved
...thm/src/main/java/com/baidu/hugegraph/computer/algorithm/path/rings/RingsDetectionValue.java Outdated Show resolved Hide resolved
...thm/src/main/java/com/baidu/hugegraph/computer/algorithm/path/rings/RingsDetectionValue.java Outdated Show resolved Hide resolved
...uter-test/src/main/java/com/baidu/hugegraph/computer/algorithm/rings/RingsDetectionTest.java Outdated Show resolved Hide resolved
...uter-test/src/main/java/com/baidu/hugegraph/computer/algorithm/rings/RingsDetectionTest.java Outdated Show resolved Hide resolved
...-algorithm/src/main/java/com/baidu/hugegraph/computer/algorithm/path/rings/SpreadFilter.java Outdated Show resolved Hide resolved
...-algorithm/src/main/java/com/baidu/hugegraph/computer/algorithm/path/rings/SpreadFilter.java Outdated Show resolved Hide resolved
...-algorithm/src/main/java/com/baidu/hugegraph/computer/algorithm/path/rings/SpreadFilter.java Outdated Show resolved Hide resolved
...uter-test/src/main/java/com/baidu/hugegraph/computer/algorithm/rings/RingsDetectionTest.java Outdated Show resolved Hide resolved
06639f6
to f0157a7
Compare 4e9d748
to d154855
Compare javeme reviewed Sep 1, 2021
...src/main/java/com/baidu/hugegraph/computer/algorithm/path/rings/standard/RingsDetection.java Outdated Show resolved Hide resolved
...ava/com/baidu/hugegraph/computer/algorithm/path/rings/filter/RingsDetectionWithProperty.java Outdated Show resolved Hide resolved
Linary previously approved these changes Sep 1, 2021
javeme reviewed Sep 7, 2021
} | ||
| ||
// Init path | ||
Id id = vertex.id(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the init id can be min id of adjacent vertices
.../main/java/com/baidu/hugegraph/computer/algorithm/path/rings/filter/RingsDetectionValue.java Outdated Show resolved Hide resolved
...lgorithm/src/main/java/com/baidu/hugegraph/computer/algorithm/path/rings/RingsDetection.java Outdated Show resolved Hide resolved
.../java/com/baidu/hugegraph/computer/algorithm/path/rings/filter/RingsDetectionWithFilter.java Outdated Show resolved Hide resolved
computer-api/src/main/java/com/baidu/hugegraph/computer/core/graph/value/StringValue.java Show resolved Hide resolved
2cad80c
to c1c70b0
Compare 101feea
to 93984c3
Compare coderzc previously approved these changes Sep 24, 2021
Linary requested changes Sep 26, 2021
...m/src/main/java/com/baidu/hugegraph/computer/algorithm/path/rings/filter/FilterDescribe.java Outdated Show resolved Hide resolved
...lgorithm/src/main/java/com/baidu/hugegraph/computer/algorithm/path/rings/RingsDetection.java Outdated Show resolved Hide resolved
computer-api/src/main/java/com/baidu/hugegraph/computer/core/graph/value/StringValue.java Outdated Show resolved Hide resolved
Linary approved these changes Sep 26, 2021
coderzc approved these changes Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.