use session timeout option for sendControlMessageToWorkers #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #92 +/- ## ============================================ - Coverage 87.86% 87.86% -0.01% - Complexity 2693 2696 +3 ============================================ Files 281 281 Lines 10204 10209 +5 Branches 847 848 +1 ============================================ + Hits 8966 8970 +4 - Misses 825 828 +3 + Partials 413 411 -2
Continue to review full report at Codecov.
|
javeme reviewed Aug 16, 2021
Comment on lines 245 to 247
| long timeout = this.transportConf.syncRequestTimeout(); | ||
| if (type == MessageType.FINISH) { | ||
| timeout = this.transportConf.finishSessionTimeout(); |
There was a problem hiding this comment.
seems names with "timeout" prefix are more readable:
syncRequestTimeout => timeoutSyncRequest
finishSessionTimeout => timeoutFinishSession
| } | ||
| | ||
| long timeout = this.transportConf.syncRequestTimeout(); | ||
| if (type == MessageType.FINISH) { |
coderzc force-pushed the use-session-timeout-option branch from dae6e9d to 03ec79f Compare javeme reviewed Sep 13, 2021
| } catch (TimeoutException e) { | ||
| throw new ComputerException("Timed out to wait for controling " + | ||
| "message(%s) to finished", e, type); | ||
| throw new ComputerException("Timeout(%sms) out to wait for " + |
javeme approved these changes Sep 13, 2021
Linary approved these changes Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.