Skip to content

Conversation

houzhizhen
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #81 (2513660) into master (5418449) will increase coverage by 0.03%.
The diff coverage is 78.78%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #81 +/- ## ============================================ + Coverage 88.33% 88.37% +0.03%  - Complexity 2628 2644 +16  ============================================ Files 270 272 +2 Lines 9827 9860 +33 Branches 825 828 +3 ============================================ + Hits 8681 8714 +33  Misses 739 739 Partials 407 407 
Impacted Files Coverage Δ
...om/baidu/hugegraph/computer/algorithm/wcc/Wcc.java 66.66% <66.66%> (ø)
...du/hugegraph/computer/algorithm/wcc/WccParams.java 100.00% <100.00%> (ø)
...k8s/operator/controller/ComputerJobController.java 88.75% <0.00%> (-1.56%) ⬇️
...mputer/k8s/operator/common/AbstractController.java 84.34% <0.00%> (+1.01%) ⬆️
...graph/computer/core/worker/ComputationContext.java 25.00% <0.00%> (+25.00%) ⬆️
...du/hugegraph/computer/core/worker/Computation.java 100.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5418449...2513660. Read the comment docs.


@Override
public String category() {
return "wcc";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer community

import com.baidu.hugegraph.testutil.Assert;
import com.baidu.hugegraph.util.Log;

public class WccTest extends UnitTestBase {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pool.shutdownNow();

Assert.assertFalse(Arrays.asList(exceptions).toString(),
existError(exceptions));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can also assert computation results are expected?

@Linary Linary merged commit 9a14659 into master Aug 11, 2021
@Linary Linary deleted the wcc branch August 11, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants