Use BytesId unify the Id classes #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Linary force-pushed the bytesid branch 5 times, most recently from bbbab12 to 9da29e2 Compare 
Codecov Report
@@ Coverage Diff @@ ## master #78 +/- ## ========================================= Coverage ? 88.46% Complexity ? 2582 ========================================= Files ? 266 Lines ? 9675 Branches ? 817 ========================================= Hits ? 8559 Misses ? 720 Partials ? 396
Continue to review full report at Codecov.
|
javeme reviewed Aug 5, 2021
computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/id/BytesId.java Outdated Show resolved Hide resolved
computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/id/BytesId.java Show resolved Hide resolved
javeme previously approved these changes Aug 6, 2021
Error: Failures: Error: MiniKubeTest.testJobFailed:187 Expected: a string containing "No such file or directory" but: was " worker failed message: Job has reached the specified backoff limit" [INFO] Error: Tests run: 521, Failures: 1, Errors: 0, Skipped: 0 |
javeme previously approved these changes Aug 10, 2021
houzhizhen previously approved these changes Aug 10, 2021
| public IdList copy() { | ||
| IdList values = new IdList(); | ||
| for (Id value : this.values()) { | ||
| values.add(value); |
houzhizhen previously approved these changes Aug 10, 2021
javeme reviewed Aug 10, 2021
| IdList values = new IdList(); | ||
| for (Id value : this.values()) { | ||
| values.add(value); | ||
| values.add((Id) value.copy()); |
There was a problem hiding this comment.
seems unneeded to always deep copy, or keep other list copy like ListValue the consistent behavior.
Linary changed the title javeme previously approved these changes Aug 11, 2021
coderzc previously approved these changes Aug 11, 2021
coderzc approved these changes Aug 11, 2021
javeme approved these changes Aug 11, 2021
Error: Failures: Error: MiniKubeTest.testJobCancelled:248 Argument(s) are different! Wanted: jobObserver.onJobStateChanged( com.baidu.hugegraph.computer.driver.DefaultJobState@37d1c5c ); -> at com.baidu.hugegraph.computer.k8s.MiniKubeTest.testJobCancelled(MiniKubeTest.java:248) Actual invocations have different arguments: jobObserver.onJobStateChanged( com.baidu.hugegraph.computer.driver.DefaultJobState@5fa53edb ); -> at com.baidu.hugegraph.computer.k8s.driver.KubernetesDriver.waitJob(KubernetesDriver.java:298) jobObserver.onJobStateChanged( com.baidu.hugegraph.computer.driver.DefaultJobState@5fa53edb ); -> at com.baidu.hugegraph.computer.k8s.driver.KubernetesDriver$1.eventReceived(KubernetesDriver.java:350) Error: Errors: Error: com.baidu.hugegraph.computer.k8s.MiniKubeTest.testPullImageError(com.baidu.hugegraph.computer.k8s.MiniKubeTest) Error: Run 1: MiniKubeTest.testPullImageError » KubernetesClient 404 page not found Error: Run 2: MiniKubeTest>AbstractK8sTest.teardown:105 » NullPointer [INFO] [INFO] Error: Tests run: 523, Failures: 1, Errors: 1, Skipped: 0 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.