Improve class for Id, Value, GraphOutput and GraphInput #6

Linary · 2021-01-05T07:53:27Z

No description provided.

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/value/ValueType.java

computer-core/src/main/java/com/baidu/hugegraph/computer/core/io/GraphWriteBackOutput.java

computer-core/src/main/java/com/baidu/hugegraph/computer/core/util/ByteArrayUtil.java

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/value/ValueType.java

computer-test/src/main/java/com/baidu/hugegraph/computer/core/graph/id/Utf8IdTest.java

computer-test/src/main/java/com/baidu/hugegraph/computer/core/graph/value/DoubleValueTest.java

...uter-test/src/main/java/com/baidu/hugegraph/computer/core/io/StreamGraphOutputInputTest.java

codecov-io · 2021-01-06T08:40:32Z

Codecov Report

Merging #6 (3337825) into master (89e35d9) will decrease coverage by 70.58%.
The diff coverage is 0.00%.

@@ Coverage Diff @@ ## master #6 +/- ## ============================================ - Coverage 70.58% 0.00% -70.59%  ============================================ Files 14 35 +21 Lines 204 753 +549 Branches 12 64 +52 ============================================ - Hits 144 0 -144  - Misses 51 753 +702  + Partials 9 0 -9

Impacted Files	Coverage Δ	Complexity Δ
...aidu/hugegraph/computer/core/common/Constants.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...idu/hugegraph/computer/core/common/SerialEnum.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...mputer/core/common/exception/ComputeException.java	`0.00% <ø> (ø)`	`0.00 <0.00> (?)`
...puter/core/common/exception/ComputerException.java	`0.00% <ø> (ø)`	`0.00 <0.00> (?)`
...ter/core/common/exception/IllegalArgException.java	`0.00% <ø> (ø)`	`0.00 <0.00> (?)`
.../computer/core/common/exception/ReadException.java	`0.00% <ø> (ø)`	`0.00 <0.00> (?)`
...computer/core/common/exception/WriteException.java	`0.00% <ø> (ø)`	`0.00 <0.00> (?)`
...du/hugegraph/computer/core/graph/id/IdFactory.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...baidu/hugegraph/computer/core/graph/id/IdType.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...baidu/hugegraph/computer/core/graph/id/LongId.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e35d9...3337825. Read the comment docs.

computer-core/src/main/java/com/baidu/hugegraph/computer/core/common/Constants.java

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/id/IdType.java

xuliguov5 · 2021-01-06T09:21:29Z

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/value/ValueType.java

 ValueType valueType = values.get(code);
 if (valueType == null) {
- String message = "Can not find ValueType for code %s.";
+ String message = "Can't find ValueType for code %s.";


ValueType -> valueType

It represent a class name

xuliguov5 · 2021-01-06T09:23:24Z

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/value/ValueType.java

+ return new IdValue();
 default:
- String message = "Can not create Value for %s.";
+ String message = "Can't create Value for %s.";


Value -> value

It represent a class name

checkstyle.xml

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/id/Id.java

javeme · 2021-01-06T11:47:40Z

computer-core/src/main/java/com/baidu/hugegraph/computer/core/io/GraphComputerInput.java

+
+ int readVInt() throws IOException;
+
+ long readVLong() throws IOException;


add more methods(from BytesBuffer class)

computer-test/src/main/java/com/baidu/hugegraph/computer/core/BaseCoreTest.java

computer-test/src/main/java/com/baidu/hugegraph/computer/core/CoreTestSuite.java

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/value/ValueType.java

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/id/LongId.java

javeme · 2021-01-06T12:04:57Z

computer-core/src/main/java/com/baidu/hugegraph/computer/core/io/StreamGraphOutput.java

+
+ @Override
+ public void writeId(Id id) throws IOException {
+ this.writeByte(id.type().code());


copy writeId() from hugegraph-core and reserve the first byte

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/id/LongId.java

javeme · 2021-01-12T03:14:10Z

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/id/UuidId.java

 public IdValue idValue() {
- int len = Byte.BYTES + Long.BYTES + Long.BYTES;
- try (ByteArrayOutputStream baos = new ByteArrayOutputStream(len)) {
+ // len = Byte.BYTES + Long.BYTES + Long.BYTES;


uuid use writeLong, fixed 8 bytes

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/value/IdValue.java

javeme · 2021-01-12T03:18:45Z

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/value/ListValue.java

+
+ @Override
+ public ValueType type() {
+ return this.valueType;


how to declare List of List<Long>

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/value/ListValue.java

checkstyle.xml

computer-core/src/main/java/com/baidu/hugegraph/computer/core/io/GraphComputerOutput.java

computer-test/src/main/java/com/baidu/hugegraph/computer/core/graph/id/IdTypeTest.java

computer-test/src/main/java/com/baidu/hugegraph/computer/core/graph/id/IdFactoryTest.java

computer-test/src/main/java/com/baidu/hugegraph/computer/core/graph/id/IdTypeTest.java

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/value/ValueFactory.java

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/value/ListValue.java

houzhizhen · 2021-01-15T09:52:04Z

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/value/ListValue.java

+ }
+
 public ListValue(ValueType elemType) {
 this.elemType = elemType;


add update element value

houzhizhen · 2021-01-15T10:03:37Z

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/value/ListValue.java


 private ValueType elemType;
 private List<T> values;



how to get element from list?

houzhizhen · 2021-01-15T10:03:52Z

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/value/ListValue.java

 private List<T> values;

+ public ListValue() {
+ this(ValueType.UNKNOWN);


add method size()

computer-core/src/main/java/com/baidu/hugegraph/computer/core/io/StructGraphOutput.java

...uter-test/src/main/java/com/baidu/hugegraph/computer/core/io/StreamGraphOutputInputTest.java

computer-core/src/main/java/com/baidu/hugegraph/computer/core/io/StreamGraphOutput.java

javeme · 2021-01-18T14:11:39Z

computer-core/src/main/java/com/baidu/hugegraph/computer/core/io/OutputFormat.java

+ BIN,
+ CSV,
+ JSON;
+


Improve class for Id, Value, GraphOutput and GraphInput

853099c

houzhizhen suggested changes Jan 5, 2021

View reviewed changes

Linary force-pushed the basic-code branch from 042720b to 817b8f6 Compare January 6, 2021 04:51

Add some test cases

2bc6ee7

Linary force-pushed the basic-code branch from 817b8f6 to 2bc6ee7 Compare January 6, 2021 05:15

houzhizhen suggested changes Jan 6, 2021

View reviewed changes

tiny improve

ef7ba72

houzhizhen previously approved these changes Jan 6, 2021

View reviewed changes

xuliguov5 reviewed Jan 6, 2021

View reviewed changes

computer-core/src/main/java/com/baidu/hugegraph/computer/core/common/Constants.java Show resolved Hide resolved

xuliguov5 reviewed Jan 6, 2021

View reviewed changes

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/id/IdType.java Outdated Show resolved Hide resolved

xuliguov5 suggested changes Jan 6, 2021

View reviewed changes

Linary dismissed houzhizhen’s stale review via 7784a8d January 6, 2021 10:00

Linary force-pushed the basic-code branch from 7784a8d to edb4d55 Compare January 6, 2021 10:08

tiny improve

b55a071

Linary force-pushed the basic-code branch from edb4d55 to b55a071 Compare January 6, 2021 10:15

javeme requested changes Jan 6, 2021

View reviewed changes

Add ListValue and improve code

1b32279

Linary force-pushed the basic-code branch from ea62498 to 1b32279 Compare January 11, 2021 07:35

javeme requested changes Jan 12, 2021

View reviewed changes

Add IdValueList and IdValueListList

2dc1fc4

javeme requested changes Jan 15, 2021

View reviewed changes

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/value/ValueFactory.java Show resolved Hide resolved

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/value/ListValue.java Show resolved Hide resolved

Let StreamGraphOutput as a proxy of DataOutputStream

477a4db

Linary force-pushed the basic-code branch from 213d629 to 477a4db Compare January 15, 2021 08:58

houzhizhen reviewed Jan 15, 2021

View reviewed changes

tiny improve

dbdb0a8

javeme requested changes Jan 16, 2021

View reviewed changes

Add CsvStructGraphOutput and JsonStructGraphOutput

3337825

javeme approved these changes Jan 18, 2021

View reviewed changes

computer-core/src/main/java/com/baidu/hugegraph/computer/core/io/OutputFormat.java

BIN,

CSV,

JSON;

Copy link

Contributor

javeme Jan 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused row

xuliguov5 approved these changes Jan 19, 2021

View reviewed changes

houzhizhen approved these changes Jan 19, 2021

View reviewed changes

houzhizhen merged commit 4522333 into master Jan 19, 2021

houzhizhen deleted the basic-code branch January 19, 2021 01:14


		int readVInt() throws IOException;

		long readVLong() throws IOException;

Improve class for Id, Value, GraphOutput and GraphInput #6

Improve class for Id, Value, GraphOutput and GraphInput #6

Uh oh!

Conversation

Linary commented Jan 5, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-io commented Jan 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Labels

5 participants

codecov-io commented Jan 6, 2021 •

edited

Loading