rename DataFileManager to FileManager #54
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #54 +/- ## ============================================ + Coverage 85.76% 85.81% +0.04% - Complexity 1490 1491 +1 ============================================ Files 156 157 +1 Lines 4918 4914 -4 Branches 405 405 ============================================ - Hits 4218 4217 -1 + Misses 465 463 -2 + Partials 235 234 -1
Continue to review full report at Codecov.
|
| /** | ||
| * @return the next data dir to persist data like vertices, edges and | ||
| * messages. | ||
| * @return the next data directory to persist data like vertices, edges and |
There was a problem hiding this comment.
describe what's "next data directory"
| * messages. | ||
| * @return the next data directory to persist data like vertices, edges and | ||
| * messages. If pass parentDirectories such as ["message", "1"], it | ||
| * return directory end with message/1. |
There was a problem hiding this comment.
First specify the parameter summary, then give an example
| * return directory end with message/1. | ||
| */ | ||
| File nextDir(); | ||
| File nextDir(String... parentDirectories); |
| File dir = this.dirs.get(index % this.dirs.size()); | ||
| for (String path : prefix) { | ||
| dir = new File(dir, path); | ||
| } |
There was a problem hiding this comment.
dir = dir + Paths.get(prefix)
| | ||
| @Override | ||
| public File nextDir() { | ||
| public File nextDir(String... prefix) { |
There was a problem hiding this comment.
removed this method.
houzhizhen force-pushed the file-generator branch from 65ebedc to 0754a9e Compare | * @return The directory of allocated local base directory. | ||
| */ | ||
| File nextDir(String... parentDirectories); | ||
| String nextBaseDirectory(); |
| /** | ||
| * @return the next file to persist data like vertices, edges and messages. | ||
| * The returned file is unique. | ||
| * @param paths The paths as sub-directory. |
| * @return the next file to persist data like vertices, edges and messages. | ||
| * The returned file is unique. | ||
| * @param paths The paths as sub-directory. | ||
| * @return A string representation of a directory "#nextBaseDirectory() + |
There was a problem hiding this comment.
A string representation of a base directory + joined string of paths
| * @return the next data directory to persist data like vertices, edges and | ||
| * messages. If pass parentDirectories such as ["message", "1"], it | ||
| * return directory end with message/1. | ||
| * FileGenerator manages the local base directories of a container. |
There was a problem hiding this comment.
Allocate a base directory each call, there may be multi base directories configured by user, generally each base directory represent a disk, allocated by round mode.
| * one local disks. | ||
| * Allocate a base directory each call. There may be multi base | ||
| * directories configured by user, generally each base directory | ||
| * represent a disk, allocated by round mode. |
| String nextDirectory(); | ||
| | ||
| /** | ||
| * Return a string representation of a allocated base directory + |
There was a problem hiding this comment.
Allocate a base directory each call, return allocated base directory + joined string of paths.
| * | ||
| * For example, the base directories configured | ||
| * ["/disk1/job_001/container_001", "/disk2/job_001/container_001"]. | ||
| * It indicates there are two base directories and one directory for one |
There was a problem hiding this comment.
each base directory for one disk
3 participants
No description provided.